-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix infinite loading of folders in shared tab #12276
Conversation
fe190c8
to
02ae5a2
Compare
Signed-off-by: ZetaTom <[email protected]>
02ae5a2
to
f4f21f6
Compare
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12276.apk |
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12276-Screenshot-blue-Light-18-40 |
Screenshot test failure seems to be unrelated, as they highlight different fragments/activities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes Bug for me
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
This change fixes an issue where users were left with an infinite Loading... message, when attempting to open a folder from the Shared tab.
Steps to reproduce
Previously the Loading... message would be displayed without any further feedback.
Supersedes #11401